Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app commands #868

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: app commands #868

wants to merge 6 commits into from

Conversation

yevheniyJ
Copy link
Collaborator

@yevheniyJ yevheniyJ commented Nov 12, 2024

  • crowdin app list
  • crowdin app install <identifier>
  • crowdin app uninstall <identifier> --force

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 46.29630% with 29 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (7b93ceb) to head (84b4967).

Files with missing lines Patch % Lines
...a/com/crowdin/cli/client/CrowdinProjectClient.java 0.00% 16 Missing ⚠️
...java/com/crowdin/cli/client/CrowdinClientCore.java 0.00% 4 Missing ⚠️
...owdin/cli/commands/actions/AppUninstallAction.java 0.00% 4 Missing ⚠️
...a/com/crowdin/cli/commands/actions/CliActions.java 0.00% 3 Missing ⚠️
...rowdin/cli/commands/picocli/AppListSubcommand.java 66.67% 0 Missing and 1 partial ⚠️
...in/cli/commands/picocli/ApplicationSubcommand.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #868      +/-   ##
============================================
- Coverage     65.94%   65.77%   -0.16%     
- Complexity     1543     1558      +15     
============================================
  Files           228      235       +7     
  Lines          6282     6336      +54     
  Branches        946      948       +2     
============================================
+ Hits           4142     4167      +25     
- Misses         1593     1621      +28     
- Partials        547      548       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yevheniyJ yevheniyJ changed the title feat: app command feat: app commands Nov 15, 2024
@yevheniyJ yevheniyJ marked this pull request as ready for review November 15, 2024 09:52
crowdin.app.usage.customSynopsis=@|fg(green) crowdin app|@ [SUBCOMMAND] [CONFIG OPTIONS] [OPTIONS]

# CROWDIN APP LIST
crowdin.app.list.usage.description=List apps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
crowdin.app.list.usage.description=List apps
crowdin.app.list.usage.description=List installed apps

Comment on lines +795 to +796
message.application.uninstall=@|green Application %s was uninstalled|@
message.application.install=@|green Application %s was installed|@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message.application.uninstall=@|green Application %s was uninstalled|@
message.application.install=@|green Application %s was installed|@
message.application.uninstall=@|green Application %s has been uninstalled|@
message.application.install=@|green Application %s has been installed|@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants