Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aur): set & force java-environment=17 #848

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tippfehlr
Copy link
Contributor

@tippfehlr tippfehlr commented Sep 26, 2024

The currently used gradlew version does not support the latest java.
To fix this, specify java-environment=17 and put any jdk17 to the front
of PATH, in case a jdk17 is not currently selected by the user.

And:

  • remove _pkgBuildVersion, use $pkgver
  • install license

Closes: #847

The currently used gradlew version does not support the latest java.
To fix this, specify java-environment=17 and put any jdk17 to the front
of PATH, in case a jdk17 is not currently selected by the user.

And:
- remove _pkgBuildVersion, use $pkgver
- install license

Closes: crowdin#847
@andrii-bodnar
Copy link
Member

@tippfehlr thanks a lot for the contribution! 🚀

@cmrd-senya could you please review this PR?

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (cb0e8eb) to head (2e4367c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #848   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity     1522     1522           
=========================================
  Files           225      225           
  Lines          6210     6210           
  Branches        940      940           
=========================================
  Hits           4092     4092           
  Misses         1576     1576           
  Partials        542      542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tippfehlr
Copy link
Contributor Author

Ah and I removed the conflicts array because crowdin-cli-bin has a conflict with crowdin-cli and this package conflicts with crowdin-cli automatically

@andrii-bodnar andrii-bodnar merged commit 484d23e into crowdin:main Oct 8, 2024
10 checks passed
@tippfehlr
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUR] gradlew fails for java != 17
2 participants