This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Fix onPageStarted/Finished never called in subclass of CordovaWebViewCl... #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Client onPageStarted/Finished are methods of XWalkClient which is internal class. For subclass of CordovaWebViewClient usage, We need to route them out. BUG=https://crosswalk-project.org/jira/browse/XWALK-1882
|
nit: nenver -> never lgtm with the above nit. |
huningxin
changed the title
|
@hmin , Commit title updated. Please take another look. |
| boolean isCurrentlyLoading; | ||
| private boolean doClearHistory = false; |
There was a problem hiding this comment.
To align with the history commit of upstream. Could you please move this line above to "boolean isCurrentlyLoading;".
There was a problem hiding this comment.
Good idea. It would be easier for next rebasing. I'll do that.
|
Updated the commit. @gaochun , please take another look. thanks. |
|
LGTM |
|
Thanks for the review. I am going to merge. |
huningxin
added a commit
that referenced
this pull request
Jun 13, 2014
Fix onPageStarted/Finished never called in subclass of CordovaWebViewCl...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ient
onPageStarted/Finished are methods of XWalkClient which is internal class.
For subclass of CordovaWebViewClient usage, We need to route them out.
BUG=https://crosswalk-project.org/jira/browse/XWALK-1882