[Backport release-1.1] Fix namespaced resources testing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Before this change any namespaced resource testing lead to generation
of malformed apply test case that led to uptest failure
```
2024/08/31 02:05:36 Error: spec.steps[1].try[1].script.content: Invalid value: v1alpha1.Script{Timeout:(*v1.Duration)(nil), Bindings:[]v1alpha1.Binding(nil), Outputs:[]v1alpha1.Output(nil), Env:[]v1alpha1.Binding(nil), Cluster:"", Content:"", SkipLogOutput:false, Check:(*v1alpha1.Any)(nil)}: content must be specified
```
* Reason of the failure is empty `content: |` in case of namespace
resources in generated `00-apply.yaml`
```
- script:
content: |
- name: Assert Status Conditions
```
* This change fixes the generation loop to enable `script` only when we
have at least 1 cluster-scoped resource
Signed-off-by: Yury Tsarev <[email protected]>
(cherry picked from commit 5049702)
Signed-off-by: Yury Tsarev <[email protected]> (cherry picked from commit 312bb2a)
Signed-off-by: Yury Tsarev <[email protected]> (cherry picked from commit 484d14e)
github-actions
bot
requested review from
ulucinar and
sergenyalcin
as code owners
1 task
sergenyalcin
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #24 to
release-1.1.