Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument ordering for manifest-files is scrambled #29

Closed
kaessert opened this issue Oct 6, 2024 · 0 comments · Fixed by #30
Closed

Argument ordering for manifest-files is scrambled #29

kaessert opened this issue Oct 6, 2024 · 0 comments · Fixed by #30
Labels
bug Something isn't working

Comments

@kaessert
Copy link
Contributor

kaessert commented Oct 6, 2024

What happened?

When running uptest and supplying manifest-paths as a comma-separated list, the list ends up scrambled sometimes. This is due to the fact that internally the slice is transformed into a map and later read out element by element though the ordering in the map is not guaranteed.

This renders the usage of pre-and post-delete hooks for deletion ordering useless as the order is never guaranteed.

How can we reproduce it?

Happens with any list of manifest files supplied as an argument.

What environment did it happen in?

  • Uptest Version: v1.1.2
@kaessert kaessert added the bug Something isn't working label Oct 6, 2024
kaessert added a commit to kaessert/uptest that referenced this issue Oct 6, 2024
@kaessert
Fix ordering of input-manifests being scrambled, closes crossplane#29
2f03591
kaessert added a commit to kaessert/uptest that referenced this issue Oct 6, 2024
@kaessert
Fix ordering of input-manifests being scrambled, closes crossplane#29
b9b9a28
@kaessert kaessert mentioned this issue Oct 6, 2024
Merged
1 task
kaessert added a commit to kaessert/uptest that referenced this issue Oct 6, 2024
@kaessert
Fix ordering of input-manifests being scrambled, closes crossplane#29
7087b86 
Signed-off-by: Tobias Kässer <[email protected]>
kaessert added a commit to kaessert/uptest that referenced this issue Oct 8, 2024
@kaessert
Fix ordering of input-manifests being scrambled, closes crossplane#29
937254d 
Signed-off-by: Tobias Kässer <[email protected]>
sergenyalcin added a commit that referenced this issue Oct 8, 2024
@sergenyalcin
Merge pull request #30 from kaessert/fix_manifest_ordering
7e8ad3e 
Fix ordering of input-manifests being scrambled, closes #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ordering of input-manifests being scrambled, closes #29 kaessert/uptest
1 participant
@kaessert