Support parent extraction from header blocks #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
add-conflicting
branch
from
21f3383
to
720caac
Compare
ulucinar
changed the title
ulucinar
force-pushed
the
add-conflicting
branch
from
720caac
to
ddc7f3d
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
add-conflicting
branch
from
ddc7f3d
to
bfc8fc4
Compare
sergenyalcin
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
I reviewed the PR together with Alper as offline. There are notable improvements on field documentations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes https://github.com/upbound/official-providers/issues/562
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually observed the generated metadata files and via https://github.com/upbound/official-providers/pull/727