Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external-name annotation configuration for examples #76

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Aug 22, 2022

Description of your changes

Currently, we do not utilize the MetaResource.ExternalName configuration while generating example manifests. This PR fixes this.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested successfully with AWS's S3 bucket:

apiVersion: s3.aws.upbound.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/external-name: ${Rand.RFC1123Subdomain}
  labels:
    testing.upbound.io/example-name: b
  name: b
spec:
  forProvider:
    region: us-west-1
    tags:
      Environment: Dev
      Name: My bucket

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ulucinar

@ulucinar ulucinar merged commit 97fd5c1 into crossplane:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants