types: do not require go binary to be present during configuration #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muvaf
changed the title
…completed in runtime Signed-off-by: Muvaffak Onus <[email protected]>
ytsarev
reviewed
Aug 8, 2022
|
|
||
| commentOptional, err = comments.New("") | ||
| if err != nil { | ||
| panic(errors.Errorf("cannot build new comment for reference fields")) |
There was a problem hiding this comment.
@muvaf is it safe to remove all additional error checking that is happening in init()?
There was a problem hiding this comment.
Yes, since it does what &comments.Comment does but by parsing the given text. Since we don't have text to parse, we can just initialize with &comments.Comment{} and not have an error to worry about at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Uptest was failing for some reason and it turns out we introduced a dependency to
typespackage from config andtypesrequiresgobinary to be present to load the packages that contain reference types. Those types are quite simple, so I just removed package loading and initialized them manually - removing the need to load any package.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
make reviewabledoesn't report any diff.