Filter sensitive fields in debug level logs #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muvaf
reviewed
Aug 9, 2022
muvaf
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
LGTM! Thanks @sergenyalcin , left some comments but none blocking.
| @@ -56,6 +56,12 @@ func WithAferoFs(fs afero.Fs) WorkspaceOption { | |||
| } | |||
| } | |||
|
|
|||
| func WithFilterFn(filterFn func(string) string) WorkspaceOption { | |||
There was a problem hiding this comment.
If you'd like to enable providers to give this, then I think a similar option for WorkspaceStore will be needed, too, because that's what they initialize in their main function. An alternative could be to create an option for WorkspaceStore that accepts a list of WorkspaceOptions to apply.
Signed-off-by: Sergen Yalçın <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #52
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This PR was tested by using a provider config that contains wrong credentials.