-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crd: remove field transformation struct and its usages #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergenyalcin thanks! I think it's not a risky change but there are conflicts with other example gen PR so I'll wait that before merging. #48 is the blocking PR actually. |
@muvaf Got it! I realized that the PR was separated after I started the review :) I will also review the blocking PR. #48 |
…commonly by different generators Signed-off-by: Muvaffak Onus <[email protected]>
…between crd generator and example generator Signed-off-by: Muvaffak Onus <[email protected]>
…ocessing Signed-off-by: Muvaffak Onus <[email protected]>
…case where there is no schema in given path Signed-off-by: Muvaffak Onus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @muvaf I did a code review and as far as I understand the most important file is example.go
In another files, mainly, changes are related the changed function call. This PR looks good to me generally.
As I said that before, these changes are related with your before works together with Alper. So apart from high-level architectural part, I focused on the code review.
Description of your changes
FieldTransformation
is the one and only struct passed as result from one generator to the other. As mentioned in #9 and #4 (review) , the information it conveys is already available. So, this PR removes it and gathers that information fromconfig.Resource
, using it as the source of truth for such info like all other mechanisms.Fixes #9
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Only the following diff is reported in the examples in
main
ofprovider-aws
: