fix unintentional modification of slice in GetSensitiveParameters #449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes the
prefixes
slice variable scope in GetSensitiveParameters()During resolution of sensitive values in secret ref, #406 introduced support for secret refs from
initProvider
fields, which introduced aprefixes
slice to both check fieldpaths starting withspec.forProvider
andspec.initProvider
In #417,
prefixes
slice was modified in the case of fieldspaths starting withstatus.atProvider.
in response to fix the associated issue.However,
prefixes
slice (that is scoped outside of for loop) was being modified in the for loop for the case above, causing remaining iterations to unintentionally operate on modified slice, resulting some secretRef fields to be not resolved into the parameters, thus failing the resource create/update operationsAffected resources are those who have connection details mapping entries include a fieldpath with
.status.atProvider
followed by some.spec.forProvider
and.spec.initProvider
entries.Related crossplane-contrib/provider-upjet-azure#873
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Manually and uptest at: crossplane-contrib/provider-upjet-azure#873