Add example converter for conversion of singleton lists to embedded objects #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
requested review from
ulucinar,
erhancagirici and
mergenci
as code owners
sergenyalcin
force-pushed
the
example-converter
branch
3 times, most recently
from
48c41b2
to
376b8e7
Compare
6 tasks
…o embedded object Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
example-converter
branch
from
376b8e7
to
0b73a9f
Compare
ulucinar
reviewed
May 13, 2024
There was a problem hiding this comment.
Thank you @sergenyalcin, left some comments for you to consider. One further point is that I feel like this conversion utility better belongs to the pkg/examples package, which contains the example manifest generation pipeline (or a subpackage of it, like pkg/examples/conversion or similar). What do you think?
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
approved these changes
May 14, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on #387
This PR adds an example converter library for conversion of singleton lists to embedded objects.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested locally against to provider-gcp.