Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap SYNCED and READY columns in output #360

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

bobh66
Copy link
Contributor

@bobh66 bobh66 commented Mar 3, 2024

Description of your changes

Crossplane creates CRDs for Claims and Composites with the additionalPrinterColumns "SYNCED" and "READY" in that order.

This PR modifies the code generation to use the same order of SYNCED and READY instead of the current READY and SYNCED.

Fixes #359

I have:

  • Read and followed Upjet's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Generated the Upbound provider-aws using these changes and confirmed that the CRDs were generated with the SYNCED and READY fields in that order

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bobh66 for the change. There's a slight possibility that there might be shell scripts that depend on the current order of the READY and SYNCED columns but I think it's better for us to align with the core Crossplane resources and I would not consider such scripts as following the best practices. I will mark the PR as breaking, treating the kubectl output as part of our contract, and it should be fine if we mention the change in the provider release notes.

@ulucinar ulucinar merged commit f043e2e into crossplane:main Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated resources have "READY SYNCED" additional columns instead of "SYNCED READY"
2 participants