Removing the applying of StateFuncs to parameters #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
requested review from
ulucinar,
erhancagirici and
mergenci
as code owners
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
fix-statefunc-call
branch
from
df203c5
to
93af08a
Compare
1 task
ulucinar
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. If we do not observe any issues with the proposed changes here in our tests in crossplane-contrib/provider-upjet-aws#1188, then we can merge this PR.
Signed-off-by: Sergen Yalçın <[email protected]>
|
Successfully created backport PR #364 for |
|
Successfully created backport PR #365 for |
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Relevant PR: crossplane-contrib/provider-upjet-aws#1188
This PR removes the applying of
StateFuncs to parameters. This PR contains a fix for the crossplane-contrib/provider-upjet-aws#1109.In the Diff function of terraform-plugin-sdk, the StateFuncs have already applied to parameters. So, when we apply the StateFuncs before the
Observe, the StateFuncs is called two times.Big portion of the StateFuncs are idempotents like
NomalizeJson,strings.ToUpperetc. However, some of them are not idempotent and we observed the problem in this type of case.During the investigations of crossplane-contrib/provider-upjet-aws#1109 issue, we observed that a problematic behavior in upjet side. The
aws.ec2.Instanceresource's fielduser_datahas aStateFuncthat calculates the hash of the provided string and stores this hash value of string in status. For this resource the StateFunc is not idempotent and this causes a problem because we call the StateFunc two times. Result of this behavior, we calculate the wrong input for the resoruce.This PR proposes removal of applying the StateFuncs to parameters. We will continue to process HCL expressions in parameters.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested against the following resources that have different StateFuncs (in AWS):