Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .license files for the JSON test artifacts #354

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Feb 23, 2024

Description of your changes

I had previously worked around the complaining reuse action on some JSON test artifacts by processing the (invalid) JSON documents with license headers in the test itself. Learning a better alternative, this PR proposes to add the .license files.

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Reuse action seems to be happy about the change here and the unit tests are passing here.

@jeanduplessis
Copy link
Collaborator

@ulucinar I found a better way to deal with "non-code" file licenses while adding REUSE to crossplane/crossplane: crossplane/crossplane#5251

Look at the .reuse/dep5 file.

It allows you to specify the license for files in a central place rather than adding multiple individual .license files.

@ulucinar
Copy link
Collaborator Author

Observing the deprecation possibility mentioned here, we've agreed to continue with the .license files.

Copy link
Member

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulucinar LGTM.

@ulucinar ulucinar merged commit 2eb7f71 into crossplane:main Feb 23, 2024
7 checks passed
@ulucinar ulucinar deleted the json-license branch February 23, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants