-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check LateInitialize management policy in Plugin Framework external client #350
Check LateInitialize management policy in Plugin Framework external client #350
Conversation
@erhancagirici, do you have any concerns over this modification? |
@ulucinar, can you please add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mergenci, let's also make sure these changes are consumed in the upbound/provider-aws
v1.1 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mergenci
Signed-off-by: Cem Mergenci <[email protected]>
5694725
to
af31423
Compare
Validation Failed: "Could not add requested reviewers to pull request." |
Description of your changes
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
I manually tested using an AWS Security Group Ingress Rule with the following configuration:
description
field is optional and is not specified in the configuration above. After the resource is created, set its description from AWS Console and trigger a reconciliation. Check thatspec.forProvider.description
andstatus.atProvider.description
are set after the reconciliation is finished.References
This PR is a follow-up to #343.