fix diff state not being set to freshly observed state for non-existing resources #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng resources Signed-off-by: Erhan Cagirici <[email protected]>
ulucinar
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks @erhancagirici, lgtm. Please also record the root cause analysis we've done for the ReplicaGroup.elasticache engine_version issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes diff state not being set to freshly observed (nil) state for non-existing resources.
This causes reconstructed prior state being used at diff that causes parsing issues for fields with validations.
Will fix crossplane-contrib/provider-upjet-aws#1071, after consumed at
provider-awsI have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Consumed at a local provider-aws build and tested with manifests specified in crossplane-contrib/provider-upjet-aws#1071 and issue is not observed.