Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(environment): add missing environment specific patches TO/FROM #332

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

haarchri
Copy link
Contributor

@haarchri haarchri commented Jan 23, 2024

Description of your changes

  • add missing environment specific patches TO/FROM

Fixes #

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@haarchri
Copy link
Contributor Author

test is running OK locally:

Running tool: /opt/homebrew/bin/go test -timeout 30s -run ^TestNewKubernetesSource$ github.com/crossplane/upjet/pkg/migration

ok  	github.com/crossplane/upjet/pkg/migration	(cached)

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @haarchri, lgtm.

@ulucinar ulucinar merged commit f34335a into crossplane:main Jan 29, 2024
6 checks passed
@haarchri haarchri deleted the fix/environment-patches branch January 29, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants