Generate a standalone "zz_generated.terraformed.go" file for each resource #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource - Each resource will now have its own resource.Terraformed interface implementation file. - The per-group "zz_generated_terraformed.go" is now split into per-resource "zz_generated.terraformed.go" files. - This helps while generating multiple versions for the CRDs. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
isolate-terraformed-implementations
branch
from
8e3db0f
to
10c1679
Compare
1 task
sergenyalcin
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Thanks @ulucinar LGMT. Also validated in the test effort of provider-aws multiversion-crds
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a change with which we start generating a standalone
zz_generated.terraformed.gofile for each resource. Each resource will now have its ownresource.Terraformedinterface implementation file. The per-groupzz_generated_terraformed.gois now split into per-resource multiplezz_generated.terraformed.gofiles (if there are multiple resources in a given API group). This helps us while generating multiple versions for the CRDs because we do not generate from scratch the old API versions of a given resource as the generation pipeline is really expensive and instead, reuse the generated old versions.Note: We will check the implications of this change on the provider repositories, such as the linter running times, etc.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually with crossplane-contrib/provider-upjet-aws#1075.