Bump hashicorp/terraform-plugin-sdk to v2.30.0 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
commented
Dec 27, 2023
| if terraformResource.Schema == nil { | ||
| p.skippedResourceNames = append(p.skippedResourceNames, name) | ||
| continue | ||
| if terraformResource.SchemaFunc == nil { |
There was a problem hiding this comment.
We may even consider panicing on these conditions.
- If schema.Resource.Schema is nil, try to populate the schema from the SchemaFunc. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
bump-tf-sdk
branch
from
da3fcaa
to
f87063b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR bumps the Terraform plugin SDK version to
v2.30.0and if theschema.Resource.Schemaisnil, populates the resource's native schema by calling theschema.Resource.SchemaFunc.The PR does not attempt to optimize the memory usage due to large resource schemas with the lazy initialization of such schemas. This could be a future optimization point for us.
Another point is that we may need to branch out the versions we consume in the providers if we figure out issues when we bump the upjet versions in those providers because the bumped TF SDK version may not be compatible with them.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested against crossplane-contrib/provider-upjet-aws#1037 using the
aws_kinesis_firehose_delivery_streamresource that @turkenf reported.