Set diff state's Attributes to nil if the resource does not exist #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Thanks @ulucinar. I validated this PR fixes the issue that we observed in azure.
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
fix-diff-state
branch
from
343f24c
to
ccb0611
Compare
mbbush
added a commit
to mbbush/upjet
that referenced
this pull request
Jan 24, 2024
This reverts commit 81e2620, reversing changes made to 1d547af. Signed-off-by: Matt Bush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We need to set diff state's
Attributestonilif the resource does not exist.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Verified in crossplane-contrib/provider-upjet-aws#1037 & crossplane-contrib/provider-upjet-azure#592.