Call the registered schema.CustomizeDiffFunc functions in the Terraform SDK-based external client #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm SDK-based external client Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR starts passing the registered
schema.CustomizeDiffFuncs to theschema.schemaMap.Difffunction so that the availableCustomizeDifffunctions in the underlying Terraform provider are utilized. We had previously considered using these custom diff functions but we could not do so previously.The strategy is now to start supplying the custom diff functions from the native schema by default but for the providers that we need to validate these registered functions are working as intended, we will just remove, and thus prevent, the custom diff functions from the schema.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested in crossplane-contrib/provider-upjet-gcp#424 with the BucketACL.storage` resource.