Put default and configured timeouts to InstanceState for using the timeouts while Observe calls #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts default and configured timeouts to
InstanceState
for using the timeouts whileObserve
calls. We had already passed the timeouts to InstanceDiff. This covers theCreate
,Update
, andDelete
calls. However, we also need to put the timeouts toInstanceState
for' Observe' calls.We caught the issue while working on the provider-gcp storage.Bucket resource. There is a retry mechanism for Observe calls in the terraform provider for the following reason:
Also, if we do not set timeouts to resource, the TF provider sets the timeouts to 20m by default. When a user tries to create a new bucket, this operation is stuck for 20m on a retry loop in the Observation state and does not return anything. So, this blocks the creation of this resource.
It seems we have already observed this issue before and set a timeout here for the storage.Bucket resource. To activate this overridden timeout, we must pass these values to the InstanceState, as I mentioned above.
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tested in provider-gcp by using the storage.Bucket resource manually.