Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular management policy - promote to BETA #284

Closed
wants to merge 3 commits into from

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Oct 3, 2023

Description of your changes

⚠️ This PR should be merged after Crossplane 1.14 is out, to avoid Providers depending on a upjet version in which GMP is already BETA.

Bumps crossplane-runtime to a version in which GMP is beta. Just bumping crossplane-runtime gave me this issue so I needed to bump a few more things.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • [] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with provider-aws, creating a DynamoDB Table with using initProvider and managementPolicies.

Signed-off-by: lsviben <[email protected]>
@lsviben lsviben changed the title Granular management policy promote to beta Granular management policy - promote to beta Oct 3, 2023
@lsviben lsviben requested a review from turkenh October 3, 2023 13:02
@lsviben lsviben changed the title Granular management policy - promote to beta Granular management policy - promote to BETA Oct 3, 2023
Copy link
Member

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @lsviben 🙌

This PR should be merged after Crossplane 1.14 is out, to avoid Providers depending on a upjet version in which GMP is already BETA.

May be we should keep this as Draft until then 🤔

Comment on lines 20 to 21
// THIS IS A BETA FIELD. It is not honored
// unless the relevant Crossplane feature flag is enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// THIS IS A BETA FIELD. It is not honored
// unless the relevant Crossplane feature flag is enabled.
// THIS IS A BETA FIELD. It will be honored
// unless the Management Policies feature is disabled.

@lsviben
Copy link
Contributor Author

lsviben commented Oct 3, 2023

Awesome, thank you @lsviben 🙌

This PR should be merged after Crossplane 1.14 is out, to avoid Providers depending on a upjet version in which GMP is already BETA.

May be we should keep this as Draft until then 🤔

Yeah I misclicked and made it into a PR. Cant find the button to make it back into a draft :D . Let me google that 🔍

@lsviben lsviben marked this pull request as draft October 3, 2023 13:14
@turkenh
Copy link
Member

turkenh commented Oct 11, 2023

Superseded by #288

@haarchri
Copy link
Contributor

Can we Close this PR ?

@turkenh
Copy link
Member

turkenh commented Dec 18, 2023

Can we Close this PR ?

yes.

@turkenh turkenh closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants