-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular management policy - promote to BETA #284
Conversation
Signed-off-by: lsviben <[email protected]>
Signed-off-by: lsviben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @lsviben 🙌
This PR should be merged after Crossplane 1.14 is out, to avoid Providers depending on a upjet version in which GMP is already BETA.
May be we should keep this as Draft until then 🤔
// THIS IS A BETA FIELD. It is not honored | ||
// unless the relevant Crossplane feature flag is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// THIS IS A BETA FIELD. It is not honored | |
// unless the relevant Crossplane feature flag is enabled. | |
// THIS IS A BETA FIELD. It will be honored | |
// unless the Management Policies feature is disabled. |
Yeah I misclicked and made it into a PR. Cant find the button to make it back into a draft :D . Let me google that 🔍 |
Signed-off-by: lsviben <[email protected]>
Superseded by #288 |
Can we Close this PR ? |
yes. |
Description of your changes
Bumps
crossplane-runtime
to a version in which GMP is beta. Just bumpingcrossplane-runtime
gave me this issue so I needed to bump a few more things.I have:
make reviewable
to ensure this PR is ready for review.[] Addedbackport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tested with provider-aws, creating a DynamoDB Table with using
initProvider
andmanagementPolicies
.