remove finalizers before deleting migrated old MRs #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erhancagirici
requested review from
ulucinar and
sergenyalcin
as code owners
|
|
sergenyalcin
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In MR API migration process, old API MRs have their reconciliation paused, new MRs with the target API is created, then the old API MRs are deleted. However, deletion gets stuck because they have a finalizer and their reconciliation operations are paused.
The MRs have single finalizer named
finalizer.managedresource.crossplane.io, which ensures the deletion of native cloud provider resource, however in this case it is a no-op, since the deletion policy isOrphanand we already would like to keep the cloud provider resource since we are just migrating it.This PR adds a new migration step for old MRs, that removes the finalizer.
Also, it fixes a bug in the sorting of the steps, when step count to be executed exceeds 10.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested