revert leaving optional for required init fields #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related to crossplane-contrib/provider-upjet-gcp#355 .
In #237, the required fields in
spec.forProvider
were set as optional due to them being replacable by the fields inspec.initProvider
(just the fields that are inspec.initProvider
not all required fields like identifiers).This also added, or rather didnt remove, the
omitempty
json tag for those fields. This causes boolean fields to not be properly late-initialized, which in turn causes the resource to be stuck inSynced: FALSE
status as it does not have all the required fields.So this PR reverts the change in which the
omitempty
tag was not being removed for fields that are required && initProvider field. Instead it removes theomitempty
for all fields that are required.Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Ran
make generate
on provider-gcp and tested running locally with a kind cluster.The resource created is the cluster from the bug issue: crossplane-contrib/provider-upjet-gcp#355 (comment)
The result is: