Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design-doc-provider-identity-based-auth.md to docs #227

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

dverveiko
Copy link
Contributor

Description of your changes

Add provider identity based document

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dverveiko, I left a few comments about broken links.

docs/design-doc-provider-identity-based-auth.md Outdated Show resolved Hide resolved
docs/design-doc-provider-identity-based-auth.md Outdated Show resolved Hide resolved
docs/design-doc-provider-identity-based-auth.md Outdated Show resolved Hide resolved
docs/design-doc-provider-identity-based-auth.md Outdated Show resolved Hide resolved
docs/design-doc-provider-identity-based-auth.md Outdated Show resolved Hide resolved
docs/design-doc-provider-identity-based-auth.md Outdated Show resolved Hide resolved
@dverveiko dverveiko force-pushed the issue-727 branch 4 times, most recently from d952aef to 7110447 Compare July 14, 2023 08:18
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dverveiko, LGTM.

@dverveiko dverveiko merged commit b70acc1 into crossplane:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants