Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make main-tf contents exported #223

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

therealmitchconnors
Copy link
Contributor

This change will allow users of upjet to test their examples against known good terraform files, instead of having to apply them e2e, which can involve creating expensive resources. @ytsarev @stevendborrelli

@Upbound-CLA
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jeanduplessis
Copy link
Collaborator

@therealmitchconnors thank you for the contribution. Would you mind signing the CLA please: https://cla.upbound.io/upbound/upjet?pullRequest=223

@therealmitchconnors
Copy link
Contributor Author

@jeanduplessis is there a reason upjet doesn't use the CNCF cla as part of the crossplane project? Each additional cla requires separate review from my legal team, which is a big ask for a small pr like this...

@jeanduplessis
Copy link
Collaborator

@therealmitchconnors Unfortunately, due to Upjet not being part of the /crossplane/ org but the /upbound/ org in GitHub, it cannot use the same CLA.

@therealmitchconnors
Copy link
Contributor Author

Now that upbound is a CNCF project, will my CLA work?

@jeanduplessis
Copy link
Collaborator

@therealmitchconnors we'll be moving this repo to the /crossplane/ GitHub org soon which will no longer require a CLA, and only require users to sign off their commits for DCO compliance.

If you are able to update your commits on this PR with a sign off I can accept them without need for CLA sign off.

@therealmitchconnors
Copy link
Contributor Author

signoff complete

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @therealmitchconnors for the PR. Could you please also rebase it?

pkg/terraform/files.go Outdated Show resolved Hide resolved
pkg/terraform/files.go Show resolved Hide resolved
Signed-off-by: Mitch Connors <[email protected]>
Signed-off-by: Mitch Connors <[email protected]>
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @therealmitchconnors,
Sorry for the huge delay in the approval, this PR went under my radar. Thank you very much again for your contribution, lgtm.

@ulucinar ulucinar merged commit a46199f into crossplane:main Dec 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants