-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make main-tf contents exported #223
Conversation
|
@therealmitchconnors thank you for the contribution. Would you mind signing the CLA please: https://cla.upbound.io/upbound/upjet?pullRequest=223 |
@jeanduplessis is there a reason upjet doesn't use the CNCF cla as part of the crossplane project? Each additional cla requires separate review from my legal team, which is a big ask for a small pr like this... |
@therealmitchconnors Unfortunately, due to Upjet not being part of the /crossplane/ org but the /upbound/ org in GitHub, it cannot use the same CLA. |
Now that upbound is a CNCF project, will my CLA work? |
@therealmitchconnors we'll be moving this repo to the /crossplane/ GitHub org soon which will no longer require a CLA, and only require users to sign off their commits for DCO compliance. If you are able to update your commits on this PR with a sign off I can accept them without need for CLA sign off. |
7ab8c0b
to
2e8e9a1
Compare
signoff complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @therealmitchconnors for the PR. Could you please also rebase it?
Signed-off-by: Mitch Connors <[email protected]>
2e8e9a1
to
c14dc93
Compare
Signed-off-by: Mitch Connors <[email protected]>
c14dc93
to
c40331d
Compare
Signed-off-by: Mitch Connors <[email protected]>
1f75c6f
to
25a4aa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @therealmitchconnors,
Sorry for the huge delay in the approval, this PR went under my radar. Thank you very much again for your contribution, lgtm.
This change will allow users of upjet to test their examples against known good terraform files, instead of having to apply them e2e, which can involve creating expensive resources. @ytsarev @stevendborrelli