Add support for categorical converters #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
2 times, most recently
from
2605aa4
to
ad98956
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
from
ad98956
to
d269972
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
8 times, most recently
from
0e39407
to
5413b2d
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
from
5413b2d
to
88dc9b6
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
from
1a0b494
to
30375fa
Compare
- Do not use dynamic Client for categorical retrieval with the Kubernetes source Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
from
30375fa
to
2303f9f
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
from
dab501d
to
2c01279
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
categorical-converters
branch
from
3cc0c1b
to
424f2cb
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds support for the categorical converters, which allows converters to work on the whole category of resources, such as the
managedresources. The migration registry allows registration of category converters via theRegistry.RegisterCategoricalConverterfunction and categorical converters receive and act on unstructured objects.It also introduces support for categorical preprocessors: A registered (with the migration registry) preprocessor is guaranteed to be run before any registered converters are run. Preprocessors can currently be registered for the CRD categories and they can be used to alter (to supply parameters to) the behavior of any converters run downstream.
We also introduce support for converters of various types such as Crossplane's
Configuration.pkg,Configuration.meta,Provider.pkg,Lock.pkg, etc., which will be employed in various migrators targeting conversions from (community or official) monoliths to provider families.We also add the
migration.PlanExecutorsupportingmigration.ExecutorCallback. APlanExecutoris responsible for driving the execution of theSteps of a migrationPlanusing its configuredExecutor. The repo currently hosts a singleExecutorimplementation:migration.ForkExecutor, which can execute migration plan steps by forking child processes.ExecutorCallbackimplementations can be used to be notified:Stepis executed. This allows a callback implementation to skip or continue with the execution of theStepor may be used to cancel the execution of thePlan.Step. This allows an implementation to be notified of a successful step execution and the execution of thePlancan be cancelled.Stepexecution failure: This allows an implementation to be notified of a failed step execution and theStepexecution may be repeated (for instance after editing any resource manifests or patch documents theSteprefers to), skipped, or thePlanexecution can be cancelled.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
The PR has been tested using upbound/extensions-migration#12.