Extend SSOP migration script and process with the local source #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend `generate-manifests.sh` to generate SSOP installation manifests out of local Configuration files/Compositions * Document it by extending existing migration step Signed-off-by: Yury Tsarev <[email protected]>
* Optimize grepping * Skip checks in places where shellcheck can't figure out dynamic `eval` and provides false negatives Signed-off-by: Yury Tsarev <[email protected]>
ezgidemirel
reviewed
May 22, 2023
Comment on lines
13
to
17
|
|
||
| if [ -n "$CONF_PATH" ]; then | ||
| echo "Generating manifests from $CONF_PATH" | ||
| apiGroups=$(grep -rh apiVersion: "$CONF_PATH" | grep -E '(aws|gcp|azure).upbound.io' | sort | uniq | tr -d '[:blank:]'| cut -d ":" -f 2) | ||
| else |
There was a problem hiding this comment.
Hey @ytsarev, there might be some MRs created with monolith providers that do not belong to any configuration/composition. Therefore, getting the existing MRs from the cluster is safer before removing monolith providers.
There was a problem hiding this comment.
Sure, but there might be cases when I want to migrate Composition within the Configuration code with API migrator in a fully offline mode and then generate the Provider installation manifests. Both options are not mutually exclusive and can coexist to satisfy multiple scenarios.
Signed-off-by: Yury Tsarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Extend SSOP migration script and process with the local source:
generate-manifests.shto generate SSOP installation manifestsout of local Configuration files/Compositions
Additionally, Comply with
shellcheck:shellcheckcan't figure out dynamicevaland provides false negatives
Signed-off-by: Yury Tsarev [email protected]
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Checked that in both cases the script generates valid installation manifests