Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge two SP migration docs into a single file #206

Merged
merged 1 commit into from
May 25, 2023

Conversation

ezgidemirel
Copy link
Member

Description of your changes

To eliminate duplicate steps, we're merging MR migration and Configuration migration guides into a single file.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

N/A

@@ -94,17 +93,13 @@ kubectl get managed
kubectl get provider.pkg
```

10. Find new dependencies and add them to `dependsOn` field in the `crossplane.yaml` file:
10. If you want to add smaller providers to a configuration's `dependsOn` list, please follow the guide and build/push/update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow the guide

Can we link that guide here?

@ezgidemirel ezgidemirel force-pushed the merge-guides branch 2 times, most recently from 124f73b to cecfcab Compare May 23, 2023 13:46
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezgidemirel I left a comment

docs/sp-migration/sp-migration.md Outdated Show resolved Hide resolved
@ezgidemirel ezgidemirel merged commit 2920aa2 into crossplane:main May 25, 2023
@ezgidemirel ezgidemirel deleted the merge-guides branch May 25, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants