Fixes and improvements in smaller provider migration docs #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
commented
May 17, 2023
| @@ -58,22 +58,22 @@ spec: | |||
| done | |||
| ``` | |||
|
|
|||
| 4. Install config providers with `revisionActivationPolicy: Manual`: | |||
| 4. Install family providers with `revisionActivationPolicy: Manual`: | |||
There was a problem hiding this comment.
Having duplicated steps across two guides is bugging me.
@ezgidemirel do you see a way to combine them?
There was a problem hiding this comment.
we can mark some of the steps as configuration only but I think it will make things more complicated for the user.
Signed-off-by: Hasan Turken <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR:
[[: not founderrors for non-bash shells.--all-namespacesfor backing claims upI have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested with platform-ref-azure.