Incorporate Feedback on the New Provider Generation Guide #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenf
force-pushed
the
improve-new-provider-generation-guide
branch
from
0bd28cd
to
94e3936
Compare
jeanduplessis
approved these changes
May 22, 2023
There was a problem hiding this comment.
Thanks for the update @turkenf – it will definitely help those who are using Upjet for the first time.
Comment on lines
+117
to
+120
| # remove the sample directory which was a configuration in the template | ||
| rm -rf config/null |
There was a problem hiding this comment.
Non-blocking question: Could we update the template so this step isn't necessary?
There was a problem hiding this comment.
I will check, and open an issue for it if possible.
turkenf
force-pushed
the
improve-new-provider-generation-guide
branch
2 times, most recently
from
63f66a5
to
59c6bf8
Compare
turkenf
force-pushed
the
improve-new-provider-generation-guide
branch
from
59c6bf8
to
90ce879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In this PR, feedback has been added to the New Provider Generation Guide.
Fixes: https://github.com/upbound/team-extensions/issues/11
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested