Include full state under status.atProvider #164
Conversation
turkenh
requested review from
sergenyalcin and
ulucinar
and removed request for
sergenyalcin
| @@ -277,6 +277,12 @@ func (r *resource) addParameterField(f *Field, field *types.Var) { | |||
| } | |||
|
|
|||
| func (r *resource) addObservationField(f *Field, field *types.Var) { | |||
| for _, obsF := range r.obsFields { | |||
| if obsF.Name() == field.Name() { | |||
| // If the field is already added, we don't add it again. | |||
There was a problem hiding this comment.
Why do observation fields get added multiple times? Is it related to this code segment? The comment above that segment states that it prevents elimination of fields in the observation type. If we are unconditionally adding every field as an observation field, can we remove that segment? And if we did so, would we still need this duplication check?
There was a problem hiding this comment.
Removing that code segment and the check here didn't work OOB. Ended up with diffs like below:
I need to investigate further and remember where those previous additions are coming from.
There was a problem hiding this comment.
I added a comment on where those previous additions are coming from.
There was a problem hiding this comment.
Thank you @turkenh for giving it a try. I believe we can rename those types if desired in a future PR once we understand the implications as they are now shared between spec.forProvider and status.atProvider, when the status.atProvider becomes a superset.
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Description of your changes
This PR changes schema generation to include the entire state under
status.atProvideras proposed in the Observe Only design doc. In other words,status.atProviderwill become superset ofspec.forProvider.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
See this PR crossplane-contrib/provider-upjet-aws#571