Rename migration.Converter.ComposedTemplates as Composition #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
migrate-patchsets
branch
10 times, most recently
from
0ee754c
to
99b4416
Compare
sergenyalcin
approved these changes
Feb 1, 2023
- And allow conversions on a Composite's spec.patchSets Signed-off-by: Alper Rifat Ulucinar <[email protected]>
- This method is called on a single migration source MR to have it converted/upgraded. So the semantics is to convert a resource. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
… migration converters Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…nd target kinds do not match - Generate unique names for target composed templates Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…targets if they conform to the target's schema - Remove patches from targets if the patch target/source field does not exist or is of a different type in the target - Include patches in targets if the patch target/source field exists and is of the same type in the target Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
migrate-patchsets
branch
from
99b4416
to
78a6825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes changes to the
migration.Converterinterface so that:migration.Converter.ComposedTemplatesis renamed toCompositionmigration.Converter.Compositionaccepts thespec.patchSetsof a Composition, andspec.patchSetsof Composition's by the registered migration converters.Also we have the following improvements for the migration converters:
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested