Use a local runtime.Scheme with the migration.Registry #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mkdir all folders before putting a file with the FileSystem target Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
local-scheme
branch
5 times, most recently
from
58dcbdc
to
91280c2
Compare
ulucinar
force-pushed
the
local-scheme
branch
from
91280c2
to
33bf49f
Compare
- Plan generated now versions the plans it generates Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
local-scheme
branch
from
33bf49f
to
6c4945f
Compare
…entation in Kubernetes migration source Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…1.Compositions - FromUnstructured may fail on v1.Compositions due to: kubernetes-sigs/structured-merge-diff#230 Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a change to use a local runtime.Scheme with the
migration.Registryinstead of a global scheme. Themigration.Registrynow has methods to register claim and composite resource types to be migrated.It also mkdirs all folders before putting a file with the FileSystem target.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested with a migrator for proviider-terraform and provider-aws resources.