Add a "--extensions" command-line option to the metadata scraper #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- Improve the error given when no markdown nodes match the prelude conditions - Make page_title in preludes optional Signed-off-by: Alper Rifat Ulucinar <[email protected]>
turkenh
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a
--extensionscommand-line option to the metadata scraper to be able to specify the file extensions to scrape and improves the error given when no markdown nodes match the prelude conditions. It also makespage_titlein the preludes optional so that if a scraped markdown file does not have it, the scraper will not complain.These changes were required to get the scraper compatible with the terraform-provider-azuread repository. Also we need to specify
//text()[contains(., "subcategory")]as the prelude xpath when scraping that repository.I have:
make reviewableto ensure this PR is ready for review.upbound/provider-{aws,gcp,azure}repositories so that no diffs are expected in repoconfig/provider-metadata.yamlfilesbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested by scraping the terraform-provider-azuread repository to generate the
config/provider-metadata.yamlfile for that repository.