Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in add-new-resource-short.md doc #117

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Oct 23, 2022

Description of your changes

This PR:

  • Fixes broken links
  • Update config method names

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

By following the doc

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turkenf Thank you for this contribution. This is very much appreciated. I left a response to your comment that is related the unresolved broken link. We can change the non-working issue link with the new one that is in my comment.

docs/add-new-resource-short.md Outdated Show resolved Hide resolved
@Upbound-CLA
Copy link

Upbound-CLA commented Oct 24, 2022

CLA assistant check
All committers have signed the CLA.

@sergenyalcin
Copy link
Member

sergenyalcin commented Oct 24, 2022

@turkenf Could you please sign the CLA?

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@sergenyalcin sergenyalcin merged commit c82119f into crossplane:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants