Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PollInterval to controller setup functions #112

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

fhopfensperger
Copy link
Contributor

Description of your changes

Add PollInterval to controller setup function template.

Fixes crossplane/terrajet#288

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make generate on a jet provider

Signed-off-by: Florian Hopfensperger [email protected]

@fhopfensperger
Copy link
Contributor Author

@muvaf as discussed in Slack

@Upbound-CLA
Copy link

Upbound-CLA commented Oct 17, 2022

CLA assistant check
All committers have signed the CLA.

@fhopfensperger
Copy link
Contributor Author

Successfully signed the CLA 😅

@muvaf
Copy link
Member

muvaf commented Oct 17, 2022

@fhopfensperger Could you try again? We're still working on the integration 😅

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fhopfensperger !! LGTM!

@muvaf muvaf merged commit 7e84c63 into crossplane:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PollInterval is not considered by controllers
4 participants