Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OP docs #109

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Move OP docs #109

merged 2 commits into from
Oct 14, 2022

Conversation

ezgidemirel
Copy link
Member

Signed-off-by: ezgidemirel [email protected]

Description of your changes

This PR adds official provider documentation to Upjet as suggested in https://github.com/upbound/squad-control-planes/issues/823

Signed-off-by: ezgidemirel <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/configuring-a-resource.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…es, update license reference

Signed-off-by: ezgidemirel <[email protected]>
@ezgidemirel ezgidemirel marked this pull request as ready for review October 14, 2022 12:39
@ezgidemirel
Copy link
Member Author

@muvaf thanks for your review. I addressed your comments. Could you please give it a second pass?

Copy link

@luebken luebken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can follow up with further PRs.

@muvaf muvaf merged commit c8b7c59 into crossplane:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants