terraform: do not fill the empty tfstate if the resource is being deleted #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eted Signed-off-by: Muvaffak Onus <[email protected]>
|
All tests have passed in three cloud providers. See status checks of this commit https://github.com/upbound/official-providers/pull/779/commits/aac5fd7a349441d5d361467a4cf8c00961dce3cd |
Signed-off-by: Muvaffak Onus <[email protected]>
sergenyalcin
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Details are in #100 but the gist is that we should not fill the tfstate during deletion since that's how TF signals that the destroy operation succeeded.
Fixes #100
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
In my local, with GCP KMS KeyRing.
All tests have passed in three cloud providers. See status checks of this commit https://github.com/upbound/official-providers/pull/779/commits/aac5fd7a349441d5d361467a4cf8c00961dce3cd