Merge pull request #149 from ulucinar/no-ext-name-in-template

Add a test-case for config.GetExternalNameFromTemplated where the external-name template variable is not available
crossplane · Jan 23, 2023 · 531a995 · 531a995
2 parents 5d0efcc + 1e90abe
commit 531a995
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/pkg/config/externalname_test.go b/pkg/config/externalname_test.go
@@ -79,6 +79,16 @@ func TestGetExternalNameFromTemplated(t *testing.T) {
 				name: "myname",
 			},
 		},
+		"NoExternalNameInTemplate": {
+			reason: "Should return the ID intact if there's no {{ .external_name }} variable in the template",
+			args: args{
+				tmpl: "olala:{{ .another }}:omama:{{ .someOther }}",
+				val:  "olala:val1:omama:val2",
+			},
+			want: want{
+				name: "olala:val1:omama:val2",
+			},
+		},
 	}
 	for name, tc := range cases {
 		t.Run(name, func(t *testing.T) {