Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Remove duplicate call to GetObservedCompositeResource in docs #46

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Mitsuwa
Copy link
Contributor

@Mitsuwa Mitsuwa commented Oct 11, 2023

Description of your changes

I believe this is a mistaken duplicate line in the README.md. The comment and call above seem to be for getting spec.widgets as well as the error check below. I believe this

oxr, err := request.GetObservedCompositeResource(req)

line, was accidently copied from line #30 above and should be removed because it is confusing here

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

this is a readme change

@Mitsuwa Mitsuwa force-pushed the duplicate-getcomposed-readme branch from b60b4fa to ccc779d Compare October 11, 2023 18:11
Copy link
Collaborator

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call! thanks @Mitsuwa!

@phisco phisco merged commit a16c73f into crossplane:main Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants