Allow falling through to the Insecure option #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If --tls-certs-dir is the empty string (i.e. not specified), we try see whether --insecure was supplied. If both are supplied, whichever was supplied last wins. If neither are supplied, you'll get an error that you didn't setup any credentials. Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/function-auto-ready
that referenced
this pull request
Sep 21, 2023
To pull in crossplane/function-sdk-go#27 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/function-dummy
that referenced
this pull request
Sep 21, 2023
To pull in crossplane/function-sdk-go#27 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/function-template-go
that referenced
this pull request
Sep 21, 2023
To bring in crossplane/function-sdk-go#27 Signed-off-by: Nic Cope <[email protected]>
This was referenced Sep 21, 2023
negz
added a commit
to negz/function-patch-and-transform
that referenced
this pull request
Sep 21, 2023
To bring in crossplane/function-sdk-go#27 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/function-patch-and-transform
that referenced
this pull request
Sep 27, 2023
Mostly to pull in crossplane/function-sdk-go#27 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/function-patch-and-transform
that referenced
this pull request
Oct 22, 2023
Mostly to pull in crossplane/function-sdk-go#27 Signed-off-by: Nic Cope <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
If --tls-certs-dir is the empty string (i.e. not specified), we try see whether --insecure was supplied. If both are supplied, whichever was supplied last wins. If neither are supplied, you'll get an error that you didn't setup any credentials.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
It has not yet. 😬 I am about to test it by bumping function-dummy to use this though.