fix missing import #565
Merged
fix missing import #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsviben <[email protected]>
phisco
approved these changes
Oct 3, 2023
turkenh
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds a missing import to the reconciler.
Seems like the merging of #556 removed the import
while #540 uses the import.
As they were worked on in paralel seems like our CI tested #556 before #540 was merged, thus giving us a green light to merge it.
The merge CI job failed, but not sure if we got the notification anywhere.
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Ran
make reviewable test