introduce Lintable interace #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsviben <[email protected]>
phisco
approved these changes
Sep 21, 2023
pedjak
suggested changes
Sep 21, 2023
| @@ -33,6 +33,12 @@ import ( | |||
| "github.com/crossplane/crossplane-runtime/pkg/errors" | |||
| ) | |||
|
|
|||
| // Lintable defines the common API for lintable packages. | |||
| type Lintable interface { | |||
| GetMeta() []runtime.Object | |||
There was a problem hiding this comment.
what is the semantic difference between these two methods, since they return the same types? Can you please add some doc?
There was a problem hiding this comment.
Added some comments, hope it makes it more clear!
Signed-off-by: lsviben <[email protected]>
pedjak
approved these changes
Sep 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Introduces a Lintable interface as a common API for lintable packages.
Resolves one of the TODO's in
up xpkgthat we are planning to move to Crossplane, sothat we avoid code duplication for the migration.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Just ran the unit tests.