Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for chainsaw download #7

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

nolancon
Copy link

This PR changes the download path for Chainsaw.

Chainsaw download path should use SAFEHOST_PLATFORM naming convention (eg linux_amd64):
https://github.com/kyverno/chainsaw/releases/download/v0.2.0/chainsaw_linux_amd64.tar.gz

not HOST_PLATFORM naming convention (eg linux_x86_64):
https://github.com/kyverno/chainsaw/releases/download/v0.2.0/chainsaw_linux_x86_64.tar.gz

@nolancon
Copy link
Author

nolancon commented Jul 3, 2024

@negz 🙏

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I quickly checked and I think SAFEHOSTARCH is needed for arm64 too (HOSTARCH would be aarch64 on Linux).

@negz negz merged commit f67b099 into crossplane:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants