Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README.md github app example secret #74

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

efekete
Copy link
Contributor

@efekete efekete commented Apr 25, 2024

The configuration is expecting list of object, the given example has invalid JSON syntax.

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The configuration is expecting list of object, the given example has invalid JSON syntax.
@AtzeDeVries AtzeDeVries merged commit bf225dd into crossplane-contrib:main Apr 26, 2024
6 checks passed
@AtzeDeVries
Copy link
Collaborator

@efekete thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants