fix reference to team in emugroupmapping #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtzeDeVries
approved these changes
Mar 4, 2024
|
@tomasmota thanks! i see i did not properly check the previous PR is see. I just assumed the CI to be ok in this case. |
|
yeah, let me know if I should do anything else before you can merge |
|
mm just trying to find out detect-noop is true (and thus not running any ci). |
AtzeDeVries
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference to the team did not specify that the slug must be used instead of the ID, so teamSlugSelector and teamSlugRef did not work. I have fixed it and tested both of them.
Also fixed the placing of commends in external_name.go, which got messed up with the earlier rebase.