add github_emu_group_mapping resource #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasmota
force-pushed
the
team-mapping
branch
from
3a8d5d1
to
7e782d2
Compare
AtzeDeVries
reviewed
Feb 29, 2024
|
@tomasmota Thanks for the contribution. Added one comment. Also can you resync since #50 just got merged and now generates a conflict. |
Merged
tomasmota
force-pushed
the
team-mapping
branch
from
7e782d2
to
2c0d540
Compare
|
I've moved it now |
|
|
tomasmota
force-pushed
the
team-mapping
branch
from
bb234bd
to
c87bcf0
Compare
|
sorry, should be good now |
AtzeDeVries
approved these changes
Feb 29, 2024
|
@tomasmota thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds github_emu_group_mapping
How has this code been tested
I have no way of adding a test case, since that would require external_groups to be added to the provider too, which would be cumbersome due to it being a data source which just gives a list of things. The way I will use this is by having the terraform provider use the external_groups data source and then fetch that data into this resource.
I have nonetheless tested it's usage manually with our groups and it works.